Refs #21442 -- Increased test coverage of requests. #17531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carltongibson
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Hey @smithdc1 — this looks great.
I think it captures everything we need for regression test purposes.
Maybe I have an example or two that we might want to look at when adding support for other content types but I don't think they're any different in structure from the ones you have for capturing the existing behaviour. (≈_You get a string_ 😜)
felixxm
force-pushed
the
ticket_21442
branch
from
74c00ee
to
76280b4
Compare
felixxm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves test coverage for requests. It includes additional coverage for some missing lines and also aims to test additional scenarios for
request.POST. I can split these out if that would be helpful.The additional
request.POSTscenarios include:POST.CONTENT_TYPE=application/json@carltongibson -- did you have any other scenarios on your list 📓