Simplified coordinate retrieval routines for GeoIP2. #17552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixxm
reviewed
Nov 30, 2023
felixxm
reviewed
Nov 30, 2023
ngnpope
force-pushed
the
geoip2-coords
branch
from
07f4eb5
to
9a951c7
Compare
|
Thanks for the review - updated. |
ngnpope
force-pushed
the
geoip2-coords
branch
from
9a951c7
to
3a57b54
Compare
Also removed dead code checking for ``None`` as ``GeoIP2.city()` cannot return ``None``.
The `ordering` argument is undocumented and of limited use, so this is effectively the same as `GeoIP2.lon_lat()`.
felixxm
force-pushed
the
geoip2-coords
branch
from
3a57b54
to
b925fef
Compare
|
@ngnpope Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Am coming back round to a bunch of patches for improving the GeoIP stuff.
Trying to break this down into small pull requests, extracting some of the minor clean up and fixes.
NoneasGeoIP2.city()` cannot returnNone``..geos()calls to.lon_lat()to.coords()to.city()instead of just.city()!.coords()as a simple alias to.lon_lat()because it is documented.orderingargument is undocumented and untested...