Fixed #35002 -- Made UniqueConstraints with fields respect nulls_distinct.

[peterthomassen]

No description provided.

[charettes]

Thanks for the patch @peterthomassen! Could you re-submit your changes against the main branch instead?

We appreciate the attention but mergers will take care to backport to 5.x, which they have already a process defined for, as opposed to forward porting to main.

[peterthomassen]

Done.

@charettes Thanks, I didn't know. I had read up on it before I pushed, and the docs say that when "working for a fix on the 1.4 branch", one would base off stable/1.4.x. That implied to me that I should start from the stable/5.0.x branch.

[charettes]

Thanks for the target adjustment and the quick patch @peterthomassen!

I think we can do without the second test given test_unique_constraint_nulls_distinct_unsupported already covers this code path here.

I think that the patch is in a good enough shape to have mergers eyes on it at this point. I suspect we'll want to rename test_unique_constraint_nulls_distinct to test_unique_constraint_index_nulls_distinct and your one test_unique_constraint_nulls_distinct but we'll see what they'll think!

[charettes]

the docs say that when "working for a fix on the 1.4 branch", one would base off stable/1.4.x. That implied to me that I should start from the stable/5.0.x branch.

That's interesting, that would explain why we've seen similar submission in the past. I wonder if we'd want to nuance the suggestion to mention that if the bug is still present in main you likely want to base of that instead.

[peterthomassen]

I think that the patch is in a good enough shape to have mergers eyes on it at this point.

Ok, I take it that this means you folks are going to make any subsequent changes, so I can go off for dinner. :)

I suspect we'll want to rename test_unique_constraint_nulls_distinct to test_unique_constraint_index_nulls_distinct and your one test_unique_constraint_nulls_distinct but we'll see what they'll think!

I like that!

[felixxm]

@peterthomassen Thanks 👍 Welcome aboard ⛵