Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #35020 -- Fixed ModelAdmin.lookup_allowed() for non-autofield primary keys. #17581

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Fixed #35020 -- Fixed ModelAdmin.lookup_allowed() for non-autofield primary keys. #17581

merged 1 commit into from
Dec 7, 2023

Conversation

sarahboyce
Copy link
Contributor

@sarahboyce sarahboyce force-pushed the 35020-DisallowedModelAdminLookup branch 3 times, most recently from 0833417 to f6f6bb3 Compare December 6, 2023 19:38
@nessita
Copy link
Contributor

nessita commented Dec 6, 2023

Hey @sarahboyce, thank you for proposing a fix so quickly! While I review and test the PR, could you please add a release note for 5.0.1? Thank you!

nessita
nessita reviewed Dec 6, 2023
View reviewed changes
Copy link
Contributor

@nessita nessita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, pending the adding of the release notes. Thank you!

@sarahboyce sarahboyce force-pushed the 35020-DisallowedModelAdminLookup branch from f6f6bb3 to 500cb2b Compare December 6, 2023 21:14
@sarahboyce
Copy link
Contributor Author

Ah sorry yes! I'm not the best at release notes or commit messages 😅 feel free to reword

@felixxm felixxm changed the title Fixed #35020 -- Fixed ModelAdmin.lookup_allowed() for non AutoField primary keys. Fixed #35020 -- Fixed ModelAdmin.lookup_allowed() for non-autofield primary keys. Dec 7, 2023
@felixxm felixxm force-pushed the 35020-DisallowedModelAdminLookup branch from 500cb2b to ad31347 Compare December 7, 2023 05:12
felixxm
felixxm reviewed Dec 7, 2023
View reviewed changes
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarahboyce Thanks 👍 I pushed edits to a release note.

tests/modeladmin/tests.py Outdated Show resolved Hide resolved
@sarahboyce @felixxm
Fixed #35020 -- Fixed ModelAdmin.lookup_allowed() for non-autofield p…
f80669d 
…rimary keys.

Thanks Joshua Goodwin for the report.

Regression in 45ecd9a.
@felixxm felixxm force-pushed the 35020-DisallowedModelAdminLookup branch from ad31347 to f80669d Compare December 7, 2023 05:16
@felixxm felixxm merged commit f80669d into django:main Dec 7, 2023
35 checks passed
@nessita nessita mentioned this pull request Feb 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nessita nessita nessita left review comments

@felixxm felixxm felixxm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sarahboyce @nessita @felixxm