Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #28404 -- Split test_null_display_for_field() test. #17713

Closed
wants to merge 1 commit into from
Closed

Refs #28404 -- Split test_null_display_for_field() test. #17713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
52 changes: 21 additions & 31 deletions tests/admin_utils/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,43 +149,33 @@ def simple_function(obj):

self.assertEqual(value, resolved_value)

def test_null_display_for_field(self):
"""
Regression test for #12550: display_for_field should handle None
value.
"""
display_value = display_for_field(None, models.CharField(), self.empty_value)
self.assertEqual(display_value, self.empty_value)

display_value = display_for_field(
None, models.CharField(choices=((None, "test_none"),)), self.empty_value
)
def test_empty_value_display_for_field(self):
tests = [
models.CharField(),
models.DateField(),
models.DecimalField(),
models.FloatField(),
models.JSONField(),
models.TimeField(),
]
for model_field in tests:
with self.subTest(model_field=model_field):
display_value = display_for_field(None, model_field, self.empty_value)
self.assertEqual(display_value, self.empty_value)

def test_empty_value_display_choices(self):
model_field = models.CharField(choices=((None, "test_none"),))
display_value = display_for_field(None, model_field, self.empty_value)
self.assertEqual(display_value, "test_none")

display_value = display_for_field(None, models.DateField(), self.empty_value)
self.assertEqual(display_value, self.empty_value)

display_value = display_for_field(None, models.TimeField(), self.empty_value)
self.assertEqual(display_value, self.empty_value)

display_value = display_for_field(
None, models.BooleanField(null=True), self.empty_value
)
def test_empty_value_display_booleanfield(self):
model_field = models.BooleanField(null=True)
display_value = display_for_field(None, model_field, self.empty_value)
expected = (
'<img src="%sadmin/img/icon-unknown.svg" alt="None" />'
% settings.STATIC_URL
f'<img src="{settings.STATIC_URL}admin/img/icon-unknown.svg" alt="None" />'
)
self.assertHTMLEqual(display_value, expected)

display_value = display_for_field(None, models.DecimalField(), self.empty_value)
self.assertEqual(display_value, self.empty_value)

display_value = display_for_field(None, models.FloatField(), self.empty_value)
self.assertEqual(display_value, self.empty_value)

display_value = display_for_field(None, models.JSONField(), self.empty_value)
self.assertEqual(display_value, self.empty_value)

def test_json_display_for_field(self):
tests = [
({"a": {"b": "c"}}, '{"a": {"b": "c"}}'),
Expand Down