Fixed #35143 -- Improved accessibility of 404/500 debug pages. #17787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the multiple failed checks; I have the pre-commit running locally now. |
thibaudcolas
suggested changes
Jan 30, 2024
|
As far as I can see, I've resolved all the issues we've found in the last two days. |
MHLut
force-pushed
the
ticket_35143
branch
2 times, most recently
from
8acfc57
to
88978f2
Compare
felixxm
reviewed
Jan 31, 2024
felixxm
changed the title
|
@MHLut Thanks for updates 👍 |
|
Note: The Selenium test that failed is As far as I know, my changes should not touch the admin, and I'm not sure where this is coming from. |
This: - changes the header, main, and footer content areas to be rendered in a <header>, <main>, and <footer> tags, - adds scope attributes to <th>, - uses <code> for a patterns list, - uses <small> instead of <span>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ticket #35143.
Notes
The HTTP 400 error page uses the same template as HTTP 500.
Requested changes
The page should have a header, main, and footer.
Done. I did not fix the indentation within the
<main>element in the HTTP 500 template because it would cause a shift in most lines. The new CSS is hence somewhat hacky.The indentation is currently inconsistent and is best fixed in a separate ticket.
Each table should have scope attributes on th elements.
Done.
Monospaced text in the patterns list should use a code element.
Done for all the pattern items in the HTTP 404 template. I kept the CSS line that sets the list font to monospace, to prevent a visual change to the list marker font.
I have also wrapped the
Python Pathvalue in the HTTP 500 page in a code block, but couldn't get a working unit test for this scenario. (there is a test draft in the related commit message).I left all other
<pre>elements without<code>for future tickets.The small text within the h1 should use a small element instead of a span.
Done. Since
<small>looked different from the original styled span, I reused the former's CSS.