Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #7732 Support for connection pooling in oracle backend #17834

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

suraj-ora-2020
Copy link

Added support for session pool in Django for oracle backend. Supported with oracledb driver.
Ticket- 7732

Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please start from fixing doc and test failures.

@suraj-ora-2020
Copy link
Author

@felixxm Updated.

Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suraj-ora-2020 Thanks 👍 I left initial comments.

I've tried to run our test suite with "pool": True and encountered dozens or errors/failures, please check them before you will mark this ready for another reviews.

django/db/backends/oracle/base.py Outdated Show resolved Hide resolved
tests/backends/oracle/tests.py Outdated Show resolved Hide resolved
docs/releases/5.1.txt Outdated Show resolved Hide resolved
django/db/backends/oracle/base.py Outdated Show resolved Hide resolved
docs/ref/databases.txt Outdated Show resolved Hide resolved
docs/ref/databases.txt Outdated Show resolved Hide resolved
docs/releases/5.1.txt Outdated Show resolved Hide resolved
@suraj-ora-2020 suraj-ora-2020 marked this pull request as draft March 25, 2024 16:20
@suraj-ora-2020 suraj-ora-2020 marked this pull request as ready for review March 26, 2024 19:18
django/db/backends/oracle/base.py Outdated Show resolved Hide resolved
django/db/backends/oracle/features.py Outdated Show resolved Hide resolved
docs/ref/databases.txt Outdated Show resolved Hide resolved
docs/releases/5.1.txt Outdated Show resolved Hide resolved
tests/backends/oracle/tests.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants