Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #23759 -- Preserved all file extensions in Storage.get_available_name(). #17881

Merged
merged 1 commit into from Feb 20, 2024

Conversation

adamzap
Copy link
Contributor

@adamzap adamzap commented Feb 19, 2024

tests/file_storage/tests.py Outdated Show resolved Hide resolved
@nessita
Copy link
Contributor

nessita commented Feb 19, 2024

Hello! Thanks for your contribution. Please remember that when this work is ready for review, you need to adjust the ticket flags in the Trac system so this PR gets added to the "branches needing review" section of the Django Developer Dahsboard. More information in these docs.

@adamzap
Copy link
Contributor Author

adamzap commented Feb 19, 2024

@nessita Done, thanks!

Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamzap Thanks 👍 I left a small suggestion regarding tests.

@felixxm felixxm changed the title Fixed #23759 -- Preserved all file extensions in Storage.get_available_name Fixed #23759 -- Preserved all file extensions in Storage.get_available_name(). Feb 20, 2024
@felixxm
Copy link
Member

felixxm commented Feb 20, 2024

@adamzap Thanks 👍

@felixxm felixxm merged commit eb2d49b into django:main Feb 20, 2024
33 checks passed
@adamzap adamzap deleted the ticket_23759 branch February 20, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants