Fixed #34917 -- Underlined Links in Django Admin. #17883
Conversation
Signed-off-by: Myrausman <maira.usman5703@gmail.com>
|
@knyghty ,I have updated the code and it's now working as expected. Could you please review it at your convenience? |
|
Can we have an option to turn this off easily? Most of our admin lists have links in every column and it will look aggressively. (Editable fields in the list as shown in the example are probably not something very popular due to the risk of data lost from concurrent editing.) |
|
@cheng-liven you can already easily turn it off by overriding the CSS, nothing more is needed here. |
|
Hello! Thanks for your contribution. Please remember that when this work is ready for review, you need to ensure that the title references the corresponding ticket and to adjust the ticket flags in the Trac system so this PR gets added to the "branches needing review" section of the Django Developer Dahsboard. More information in these docs. |
Myrausman
changed the title
Myrausman
changed the title
Myrausman
changed the title
sarahboyce
added
selenium
There was a problem hiding this comment.
Thank you for this @Myrausman this looks a great start ⭐
The scope of the ticket describes that all links in the "main content area" of the admin should be underlined. "main content area" is defined as "not the header or nav sidebar".
This currently only covers links for the admin change list. I beleive the scope is a bit larger, as other admin pages are not included here.
Some things that come to mind and need investigating include:
We need a decision on more custom things like if a form added a link in a help text.
Can you investigate some of the other pages of the Django admin and confirm if we need to do more css updates to cover these?
Fixed ticket #34917 - Links in the Django admin are now underlined.