Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #35286 -- Updated broken link in django/template/smartif.py docstring. #17961

Merged
merged 1 commit into from Mar 10, 2024

Conversation

umair313
Copy link
Contributor

@umair313 umair313 commented Mar 10, 2024

Trac ticket number

ticket-35286

Branch description

in template/smartif.py the reference URL for top-down parsing is dead. updated that URL with from web-archive.

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • For UI changes, I have attached screenshots in both light and dark modes.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

@felixxm felixxm changed the title fixed: #35286 - Update reference URL for top-down parsing Fixed #35286 -- Updated broken link in django/template/smartif.py docstring. Mar 10, 2024
@felixxm
Copy link
Member

felixxm commented Mar 10, 2024

@umair313 Thanks 👍 Welcome aboard ⛵

@felixxm felixxm merged commit 4114179 into django:main Mar 10, 2024
34 checks passed
@umair313
Copy link
Contributor Author

@umair313 Thanks 👍 Welcome aboard ⛵

Thank you @felixxm ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants