-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter union #18023
base: main
Are you sure you want to change the base?
Add filter union #18023
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
The ticket mentions this is a WIP, it would be helpful to also change this PR to "draft" :) |
@shangxiao I made some changes and tests started to fail, can you please help me with running tests in debug? I dk how to launch test in vscode( |
Here's the guide for running tests locally: https://docs.djangoproject.com/en/5.0/internals/contributing/writing-code/unit-tests/ I don't use vscode myself but I reckon there must be a way ;) PS: You'll be better off asking for help over on the Django Discord as there are heaps of friendly active community members, whereas I'm on & offline depending on $job requirements/timezone/etc. Discord: https://www.djangoproject.com/community/ |
Trac ticket number
ticket-[28519]
Branch description
Provide a concise overview of the issue or rationale behind the proposed changes.
Checklist
main
branch.