Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made postgresql.tests.Tests.test_connect_pool less flakey by increasing timeout value. #18061

Merged
merged 1 commit into from Apr 10, 2024

Conversation

sarahboyce
Copy link
Contributor

Trac ticket number

N/A

Branch description

Aims to address this flakey ci failure for postgresql.tests.Tests.test_connect_pool

psycopg_pool.PoolTimeout: couldn't get a connection after 0.10 sec

When not set, the default timeout value is 30 seconds.
During the development of the connection pool feature, testing locally 30 seconds was very slow and so I updated to 0.1 seconds to get quick feedback on failures. This value might be too quick for the ci on occasions and hoping 5 seconds is a good compromise.

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.

Copy link
Contributor

@nessita nessita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@nessita nessita merged commit f973a70 into django:main Apr 10, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants