Fixed #21201 -- Enable customization of ClearableFileInput #1807
Conversation
| @@ -330,12 +330,10 @@ class ClearableFileInput(FileInput): | |||
| input_text = ugettext_lazy('Change') | |||
| clear_checkbox_label = ugettext_lazy('Clear') | |||
|
|
|||
| template_with_initial = '%(initial_text)s: %(initial)s %(clear_template)s<br />%(input_text)s: %(input)s' | |||
| template_with_initial = '%(initial_text)s: <a href="%(initial_url)s">%(initial)s</a> %(clear_template)s<br />%(input_text)s: %(input)s' | |||
There was a problem hiding this comment.
Removing url_markup_template breaks the customization use case in #19464.
There was a problem hiding this comment.
I checked, but I haven't found it in docs.
I investigated the related ticket, but I didn't get if there is a reason to have template split between two attributes? Or is it only a matter of backwards compatibility?
There was a problem hiding this comment.
I think the idea was to replace with . Maybe the change is fine as I guess it's still possible; it just requires overriding the entire
template_with_initial instead of url_markup_template.
There was a problem hiding this comment.
Replace the link with img is possible by changing the template_with_initial, so I didn't made any further changes.
Adding extra methods into ClearableFileInput widget to enable easier customization of the widget.
ziima
force-pushed
the
ticket_21201-clearable-file-input
branch
from
f794876
to
6098e3b
Compare
|
Rebased on master, moved the relase notes from 1.7 to 1.8. |
|
buildbot, test this please. |
|
merged in e622caa, thanks. |
Adding extra methods into ClearableFileInput widget to enable
easier customization of the widget.