Refs #31405 -- Moved redirect_to_login to utils.py. #18072
Conversation
There was a problem hiding this comment.
This also needs a release note in 5.1, see this PR as an example of a similar change 👍
| @@ -231,7 +231,7 @@ def inner(request, *args, **kwargs): | |||
| return HttpResponseRedirect(index_path) | |||
| # Inner import to prevent django.contrib.admin (app) from | |||
| # importing django.contrib.auth.models.User (unrelated model). | |||
| from django.contrib.auth.views import redirect_to_login | |||
| from django.contrib.auth.utils import redirect_to_login | |||
There was a problem hiding this comment.
Can you move this to be imported at the top?
|
|
||
| # For backwards compatibility with Django < 5.1 | ||
| from django.contrib.auth.utils import redirect_to_login # NOQA: F401 |
There was a problem hiding this comment.
I'm wondering if we have to do this, if so we should have a deprecation message.
Looking at this PR which is a little similar (#17050) looks like we don't necessarily need to. 🤔
|
@Hisham-Pak I've had a discussion with some other contributors on Discord and, as this refactor requires a deprecation without a meaningful gain to a user, we've decided it doesn't make sense. I appreciate you did this after my suggestion and thank you for doing so. |
Trac ticket number
ticket-31405
Branch description
This pull request moves
redirect_to_loginto a new fileutils.pyfromviews.pyin order to avoid circular import instead of importing locally in a function.#17792 (comment)
Checklist
mainbranch.