Fixed #35373 -- Fixed a crash when indexing a generated field on SQLite. #18079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shangxiao
reviewed
Apr 16, 2024
felixxm
reviewed
Apr 16, 2024
charettes
force-pushed
the
ticket-35376-sqlite-generated-field-remake
branch
3 times, most recently
from
5abb2a4
to
cb04704
Compare
sarahboyce
changed the title
Generated fields have to be excluded from the INSERT query against the remade table including the index. Thanks Moshe Dicker for the report, David Sanders and Mariusz Felisiak for the review.
sarahboyce
force-pushed
the
ticket-35376-sqlite-generated-field-remake
branch
from
cb04704
to
6d9aaf4
Compare
sarahboyce
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-35373
Branch description
Generated fields have to be excluded from the INSERT query against the remade table including the index.
Thanks Moshe Dicker for the report.