Fixed #35422 -- Fixed migrations crash when altering GeneratedField referencing rename field. #18122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok so MySQL doesn't support repointing field references in generated field expressions so we might need a feature flag for that? |
Maybe it's enough to skip these tests on MySQL 🤔 MySQL raises a really clear error message: "Column 'pink' has a generated column dependency.", so I would leave it as it is. |
|
Sounds good to me! |
felixxm
force-pushed
the
issue-35422
branch
2 times, most recently
from
11afe92
to
89ee1db
Compare
sarahboyce
approved these changes
May 3, 2024
…eferencing rename field. Thanks Sarah Boyce for the report and Simon Charette for the implementation idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks Sarah Boyce for the report and Simon Charette for the implementation idea.
ticket-35422