Fixed #35429 -- Added argparse choices to --database options. #18130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
saJaeHyukc
force-pushed
the
issue-35429
branch
3 times, most recently
from
1d5c9b7
to
a7124ec
Compare
|
Thanks for the change and test, good work getting this started. The point of the ticket is to edit all relevant commands not just migrate - please track down every one that has a --database option. |
Thank you :) I will re-apply it after all the changes |
saJaeHyukc
force-pushed
the
issue-35429
branch
5 times, most recently
from
9bdbbd8
to
4fcc7d9
Compare
felixxm
reviewed
May 5, 2024
sarahboyce
reviewed
May 7, 2024
saJaeHyukc
force-pushed
the
issue-35429
branch
2 times, most recently
from
f4bcc25
to
021f7ae
Compare
sarahboyce
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-35429
Branch description
Provide a concise overview of the issue or rationale behind the proposed changes.
Checklist
mainbranch.