-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refs #35380 -- Updated outdated images in docs/ref/contrib/admin/_images/. #18185
base: main
Are you sure you want to change the base?
Conversation
There are two screenshots that were updated:
|
338de1c
to
8bbe18b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to switch from 800-wide to 1020-wide? (same question for the second image)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, regenerating for 800 wide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is adding the "Django administration header" a wanted change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered it to be nicer because since both screenshots are in the same section, they felt more consistent. I think either both have the header, or none has. Any opinion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the header of the previous image is nice for the context of the green banner (maybe) but I am ok to remove it.
It's quite nice to keep the screenshots limited so they don't need frequent updates (so perhaps best not to have the header here).
As a todo, we probably should update the images in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the header of the previous image is nice for the context of the green banner (maybe) but I am ok to remove it.
It's quite nice to keep the screenshots limited so they don't need frequent updates (so perhaps best not to have the header here).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're missing selecting one of the rows here
Trac ticket number
Refs ticket-35380
Branch description
Updated admin screenshots used in the admin docs prior to feature freeze and stable/5.1.x branch cut happening on May 22nd.
Checklist
main
branch.