Make templates more reusable by Improving template loading algorithm to avoid extending infinite recursion #217

Closed
wants to merge 8 commits into
from

Conversation

Projects
None yet
5 participants
@goinnn
Contributor

goinnn commented Jul 18, 2012

@akaariai

This comment has been minimized.

Show comment
Hide comment
@akaariai

akaariai Jul 16, 2012

Please remove...

Please remove...

This comment has been minimized.

Show comment
Hide comment
@goinnn

goinnn Jul 17, 2012

Owner

This was removed in this commit (2 minutes after) bf23921

Owner

goinnn replied Jul 17, 2012

This was removed in this commit (2 minutes after) bf23921

@yedpodtrzitko

This comment has been minimized.

Show comment
Hide comment
@yedpodtrzitko

yedpodtrzitko Jul 18, 2012

What is this if-else for, when it contains the same code?

What is this if-else for, when it contains the same code?

This comment has been minimized.

Show comment
Hide comment
@leotrubach

leotrubach Jul 18, 2012

Probably LoaderOriginLite should be in the second line

Probably LoaderOriginLite should be in the second line

This comment has been minimized.

Show comment
Hide comment
@goinnn

goinnn Jul 18, 2012

Contributor

This a intermediate step. Please, see the final diff:

https://github.com/django/django/pull/217/files#L2R81

Contributor

goinnn replied Jul 18, 2012

This a intermediate step. Please, see the final diff:

https://github.com/django/django/pull/217/files#L2R81

@goinnn

This comment has been minimized.

Show comment
Hide comment
@goinnn

goinnn Jul 24, 2012

Contributor

didn't I convince you? :-( Tell me something

Contributor

goinnn commented Jul 24, 2012

didn't I convince you? :-( Tell me something

@apollo13

This comment has been minimized.

Show comment
Hide comment
@apollo13

apollo13 Jan 1, 2013

Member

@goinnn as @akaariai noted on the ticket this patch needs tests and docs! (And yes I'd really like to see this feature in core :))

Member

apollo13 commented Jan 1, 2013

@goinnn as @akaariai noted on the ticket this patch needs tests and docs! (And yes I'd really like to see this feature in core :))

@goinnn

This comment has been minimized.

Show comment
Hide comment
@goinnn

goinnn Jan 2, 2013

Contributor

Hi @apollo13. I'm sorry but I was trying for two years to add this feature. I'm bored to try it. If you can get it. Congratulantions!

Contributor

goinnn commented Jan 2, 2013

Hi @apollo13. I'm sorry but I was trying for two years to add this feature. I'm bored to try it. If you can get it. Congratulantions!

@apollo13

This comment has been minimized.

Show comment
Hide comment
@apollo13

apollo13 Jan 2, 2013

Member

Ok, closing for now then. If someone else wants to work on it please open a new pull request for review.

Member

apollo13 commented Jan 2, 2013

Ok, closing for now then. If someone else wants to work on it please open a new pull request for review.

@apollo13 apollo13 closed this Jan 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment