Skip to content

Make templates more reusable by Improving template loading algorithm to avoid extending infinite recursion #217

Closed
wants to merge 8 commits into from

5 participants

@akaariai
Django member

Please remove...

This was removed in this commit (2 minutes after) bf23921

@yedpodtrzitko

What is this if-else for, when it contains the same code?

Probably LoaderOriginLite should be in the second line

This a intermediate step. Please, see the final diff:

https://github.com/django/django/pull/217/files#L2R81

@goinnn
goinnn commented Jul 24, 2012

didn't I convince you? :-( Tell me something

@apollo13
Django member
apollo13 commented Jan 1, 2013

@goinnn as @akaariai noted on the ticket this patch needs tests and docs! (And yes I'd really like to see this feature in core :))

@goinnn
goinnn commented Jan 2, 2013

Hi @apollo13. I'm sorry but I was trying for two years to add this feature. I'm bored to try it. If you can get it. Congratulantions!

@apollo13
Django member
apollo13 commented Jan 2, 2013

Ok, closing for now then. If someone else wants to work on it please open a new pull request for review.

@apollo13 apollo13 closed this Jan 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.