Fixed #14760 - Admin inlines with file/image field fails to save_as #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_as Refactored BaseInlineFormSet and ModelAdmin to copy initial values (file name) for fields of FileField or it's subclasses. 'physical' file do not get duplicated.
| from django.http.response import HttpResponseBase | ||
| from django.http import Http404, HttpResponseRedirect |
There was a problem hiding this comment.
Please don't move import. Also the import in the line below should be alphabetized.
|
Please send a new PR if you'd like to revisit this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#697 reworked for master.
Refactored BaseInlineFormSet and ModelAdmin to copy initial
values (file name) for fields of FileField or it's subclasses.
'physical' file do not get duplicated.