Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to use local_concrete_fields instead of local_fields. #2265

Closed
wants to merge 1 commit into from

Conversation

rogerhu
Copy link
Contributor

@rogerhu rogerhu commented Feb 12, 2014

Fixes issue with ForeignObject bulk creation.

See ticket: https://code.djangoproject.com/ticket/21566

@timgraham
Copy link
Member

As noted @bmispelon on the linked PR: "Can you try and backport it to the 1.5 branch too? If things worked in 1.5 then this is definitely a regression and warrants a backport.
Otherwise I'd need to check with someone who knows the ORM internals better than me whether this change is safe to backport."

@timgraham
Copy link
Member

The ForeignObject stuff is new in 1.6 (266de5f and 9777442), so I'm pretty sure this qualifies for a backport. Merged in 9a44621.

@timgraham timgraham closed this Feb 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants