Added current datetime as output in Django devserver as per ticket 18611 #236

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@mgrouchy
Contributor

mgrouchy commented Jul 28, 2012

@mgrouchy

This comment has been minimized.

Show comment
Hide comment
@mgrouchy

mgrouchy Aug 13, 2012

Contributor

thoughts?

Contributor

mgrouchy commented Aug 13, 2012

thoughts?

@claudep

View changes

django/core/management/commands/runserver.py
"Django version %(version)s, using settings %(settings)r\n"
"Development server is running at http://%(addr)s:%(port)s/\n"
"Quit the server with %(quit_command)s.\n"
) % {
+ "started_at": strftime('%B %d, %Y - %I:%M %p',
+ datetime.timetuple(datetime.now())),

This comment has been minimized.

@claudep

claudep Aug 25, 2012

Member

simpler: datetime.now().strftime(''%B %d, %Y - %X')

@claudep

claudep Aug 25, 2012

Member

simpler: datetime.now().strftime(''%B %d, %Y - %X')

This comment has been minimized.

@mgrouchy

mgrouchy Aug 25, 2012

Contributor

Much simpler, thanks for the feedback. Updated!

@mgrouchy

mgrouchy Aug 25, 2012

Contributor

Much simpler, thanks for the feedback. Updated!

@mjtamlyn

View changes

django/core/management/commands/runserver.py
@@ -1,4 +1,6 @@
from optparse import make_option
+from datetime import datetime
+from time import strftime

This comment has been minimized.

@mjtamlyn

mjtamlyn Sep 3, 2012

Member

This is now an unused import - strftime is a method of the datetime instance

@mjtamlyn

mjtamlyn Sep 3, 2012

Member

This is now an unused import - strftime is a method of the datetime instance

This comment has been minimized.

@mgrouchy

mgrouchy Sep 5, 2012

Contributor

ah yes. cause I updated the code based on previous feedback, dont know how
I missed it. I will update that asap.

On Mon, Sep 3, 2012 at 3:18 PM, Marc Tamlyn notifications@github.comwrote:

In django/core/management/commands/runserver.py:

@@ -1,4 +1,6 @@
from optparse import make_option
+from datetime import datetime
+from time import strftime

This is an unused import - strftime is a method of the datetime instance


Reply to this email directly or view it on GitHubhttps://github.com/django/django/pull/236/files#r1518689.

@mgrouchy

mgrouchy Sep 5, 2012

Contributor

ah yes. cause I updated the code based on previous feedback, dont know how
I missed it. I will update that asap.

On Mon, Sep 3, 2012 at 3:18 PM, Marc Tamlyn notifications@github.comwrote:

In django/core/management/commands/runserver.py:

@@ -1,4 +1,6 @@
from optparse import make_option
+from datetime import datetime
+from time import strftime

This is an unused import - strftime is a method of the datetime instance


Reply to this email directly or view it on GitHubhttps://github.com/django/django/pull/236/files#r1518689.

@mgrouchy

This comment has been minimized.

Show comment
Hide comment
@mgrouchy

mgrouchy Sep 10, 2012

Contributor

Updated as per feedback from @mjtamlyn.

Contributor

mgrouchy commented Sep 10, 2012

Updated as per feedback from @mjtamlyn.

@mjtamlyn

This comment has been minimized.

Show comment
Hide comment
@mjtamlyn

mjtamlyn Sep 10, 2012

Member

Looks good, I've marked the ticket as RFC.

Member

mjtamlyn commented Sep 10, 2012

Looks good, I've marked the ticket as RFC.

@claudep

This comment has been minimized.

Show comment
Hide comment
@claudep

claudep Sep 10, 2012

Member

Committed in cb1614f

Member

claudep commented Sep 10, 2012

Committed in cb1614f

@claudep claudep closed this Sep 10, 2012

sztrovacsek pushed a commit to sztrovacsek/django that referenced this pull request Mar 7, 2015

nanuxbe pushed a commit to nanuxbe/django that referenced this pull request Jul 2, 2016

Merge pull request #236 from django/overview-redirect
Added a non-permanent redirect for /overview/.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment