Fixed #18773 -- Add logging for template variable resolving #2552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a django.template logger with a default null handler. Added logging if there is an exception while resolving variables in a template. Added corresponding tests and updated logging documentation. Updated StartProject tests to handle the stream output indicating the log handler is missing.
| @@ -413,7 +413,7 @@ requirements of logging in Web server environment. | |||
| Loggers | |||
| ------- | |||
|
|
|||
| Django provides four built-in loggers. | |||
| Django provides five built-in loggers. | |||
There was a problem hiding this comment.
I'd prefer to say "several" so we don't need to update it again.
|
Closing in absence of follow-up. Please send a new PR if you can update it, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a django.template logger with a default null handler. Added
logging if there is an exception while resolving variables in a
template. Added corresponding tests and updated logging
documentation.