Fixed #20916 - Added support for a simple_login test client method.
#2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`simple_login` takes a user instance and logs you in as that user. Ticket: 20916.
| @@ -107,6 +109,9 @@ def setup_test_environment(): | |||
| request._original_allowed_hosts = settings.ALLOWED_HOSTS | |||
| settings.ALLOWED_HOSTS = ['*'] | |||
|
|
|||
| auth._original_authentication_backends = settings.AUTHENTICATION_BACKENDS | |||
There was a problem hiding this comment.
Shouldn't this patching happen in the simple_login() method? Otherwise, login() is affected as well which means it wouldn't reject invalid credentials Am I missing something?
|
Closing in absence of follow-up. Please send a new PR if you can update it, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple_logintakes a user instance and logs you in as that user. You no longer have to manage user credentials in tests.Ticket: 20916.
Todo: