Fixed #22486 -- Reverse raises AttributeError on partial functions. #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -270,6 +270,9 @@ def _populate(self): | |||
| self._callback_strs.add(pattern._callback_str) | |||
| elif hasattr(pattern, '_callback'): | |||
| callback = pattern._callback | |||
| if hasattr(callback, 'func'): | |||
There was a problem hiding this comment.
would isinstance(calback, functools.partial) be better?
There was a problem hiding this comment.
Good point. That's more explicit than using duck-typing.
There was a problem hiding this comment.
Commit updated.
Create the lookup_str from the original function whenever a partial is provided as an argument to a url pattern.
|
merged in 3c06b2f, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the lookup_str from the original function whenever a partial
is provided as an argument to a url pattern.