Fixed #22531 and added tests for tree.Node
#2628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A test would be good. |
|
Thanks Tim for your feedback. After examining the internal tests of Django, I couldn't find a suitable place where a test for this function would really belong. |
|
I would add a new file: |
|
Can one of the admins verify this patch? |
While Node class has a useful `__str__`, its `__repr__` is not that useful. Added a `__repr__` that makes use of the current `__str__`. This is especially useful since the more popular `Q` class inherits `tree.Node`. Also created new tests that cover most of `Node` class functionality.
mmardini
changed the title
__repr__ for tree.Nodetree.Node
|
Added a new tests file. Please verify it too. |
|
Looks good. There were a couple minor flake8 warnings I fixed. merged in 393ddc1. |
|
Thanks Tim for the review. I will check using flake8 in my future PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While Node class has a useful
__str__, its__repr__is not thatuseful. Added a
__repr__that makes use of the current__str__.This is especially useful since the more popular
Qclass inheritstree.Node.