Show what module/function is missing when raised. #2871
Conversation
|
Could you add a test? |
|
Yea I can make a test for it. Wasn't sure it needed it since it was just adding the missing variables. |
|
Thanks I created a ticket for the issue so you can refer to it in the commit message. See also our patch review checklist. |
|
Okay cool. Sorry for making you do all this work I should have done it. I just wasnt sure what it warrented. |
| return "somewhere dynamic" | ||
| thing = models.FileField(upload_to=upload_to) | ||
|
|
||
| with self.assertRaisesRegexp(ValueError, |
There was a problem hiding this comment.
Need to use six.assertRaisesRegex for Python 3 compatibility
|
Could you squash commits and follow the commit message guidelines as noted in the checklist I linked above? Note since this PR is against stable/1.7.x the message should be prefixed with [1.7.x]. For future reference, it's a tiny bit easier if you submit the PR against master and then let the committer backport from there, but it's not worth creating a new PR at this point. Thanks! |
|
I squashed them down and updated the message. Ill make sure to do that next time. |
|
Oops, the test didn't actaully work after switching to six, but I fixed it and merged in f5740af. Thanks Colin. |
|
Thanks Tim! Sorry for all the issues. |
Related to comment on 98949e3