Adds 'true' and 'false' to NullBooleanField.
#3000
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review the contributing guidelines and change your commit message accordingly. |
| submit for True and False, for 'true' and 'false', which are likely to be returned by | ||
| JavaScript serializations of forms, and for '1' and '0', which is what a RadioField will | ||
| submit. Unlike the Booleanfield we need to explicitly check for True, because we are not | ||
| using the bool() function |
There was a problem hiding this comment.
Any reason why this was enlarged?
There was a problem hiding this comment.
Nope, just fat-fingered my line wrapping.
|
Thanks, I will do so as soon as I'm back at a computer!
|
JavaScript serializations of forms will sometimes render the boolean values as the strings 'true' and 'false', in lower case. Rather than repeat boilerplate in the JavaScript to circumvent this, it seems reasonable to allow Django to understand the lower-case versions of the booleans.
|
buildbot, test this please. |
|
merged in 17e75d0, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaScript serializations of forms will sometimes render the boolean values as the strings 'true' and 'false', in lower case. Rather than repeat boilerplate in the JavaScript to circumvent this, it seems reasonable to allow Django to understand the lower-case versions of the booleans.
Related to ticket 23129