Fixed #23341 -- Better stacktrace error for makemigrations #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add tests for this? It seems these errors currently aren't covered: http://djangoci.com/job/django-coverage/HTML_Coverage_Report/_home_jenkins_workspace_django-coverage_django_db_migrations_graph.html#n38 |
| if child not in self.nodes: | ||
| raise KeyError("Dependency references nonexistent child node %r" % (child,)) | ||
| raise KeyError("In migration %s dependency references nonexistent child node %r" % (migration, child,)) |
There was a problem hiding this comment.
no longer need trailing comma in tuple here and below
I'd chop "In" from the message, otherwise it looks good.
rsalmaso
force-pushed
the
tickets/23341
branch
from
5862ef9
to
317269b
Compare
|
Updated PR with tests for add_dependency. |
| graph.add_node(("app_b", "0001"), None) | ||
| graph.add_dependency("app_a.0003", ("app_a", "0003"), ("app_a", "0002")) | ||
| graph.add_dependency("app_a.0002", ("app_a", "0002"), ("app_a", "0001")) | ||
| with self.assertRaises(KeyError) as ex: |
There was a problem hiding this comment.
assertRaisesMessage (and then can also remove as ex)
Show the migration display name when references nonexistent migration(s)
rsalmaso
force-pushed
the
tickets/23341
branch
from
317269b
to
474e1c7
Compare
|
Updated PR |
|
buildbot, test this please. |
|
merged in abd640f, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show the migration display name when references
nonexistent migration(s)
Refs https://code.djangoproject.com/ticket/23341