Fixed #23434 -- Coerce Oracle bool params to int #3190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like py2 tests pass on Oracle, and I personally checked that a subset of the py3 tests pass on Oracle. |
|
merged in 638d139. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oracle boolean query parameters are coerced to the strings "1" and "0" rather than the ints 1 and 0. This causes issues when trying to write a query like:
These kinds of queries can be generated with #2496 , and prevent result converters from operating on the correct type. By changing the parameters to integers, we get the appropriate type back from the database (a number), and the converters correctly change that value to the appropriate bool.