Fixed #23606 -- Implement the RequestFactory trace() method #3353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.request_factory = RequestFactory() | ||
|
|
||
| def tearDown(self): | ||
| del(self.request_factory) |
There was a problem hiding this comment.
Should be del self.request_factory.
|
Commit f863574 changes the |
| @@ -22,7 +22,7 @@ restricted subset of the test client API: | |||
| * It only has access to the HTTP methods :meth:`~Client.get()`, | |||
| :meth:`~Client.post()`, :meth:`~Client.put()`, | |||
| :meth:`~Client.delete()`, :meth:`~Client.head()` and | |||
| :meth:`~Client.options()`. | |||
| :meth:`~Client.options()`, :meth:`~Client.trace()`. | |||
There was a problem hiding this comment.
Need to move the "and" from line 24.
There was a problem hiding this comment.
Oops.. Fixed in 0c5a657
|
You can go ahead and squash your commits after those updates, thanks. |
|
I've submitted the changes, as suggested. Thanks for the feedback. |
| """ | ||
| Send a TRACE request to the server. | ||
|
|
||
| :param path: the Request-URI |
There was a problem hiding this comment.
same comment about comment style applies here
|
Could you squash the commits please? |
The RequestFactory class did not implement a trace() method, and
therefore raised an AttributeError when used to create TRACE requests.
This change implements a factory method that returns a very basic TRACE
request object, which should be suitable for most test cases.
It also reworks the original TestClientTests suite so that the following
conditions are checked:
- The test factory can create requests for all the HTTP/1.1 methods;
- The GET request test is tested separately;
- The TRACE request is tested with a test view that simulates the
echo response, according to rfc2616.
|
I have now squashed all the my commits. |
|
buildbot, test this please. |
|
merged in 2863439, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RequestFactory class did not implement a trace() method, and
therefore raised an AttributeError when used to create TRACE requests.
This change implements a factory method that returns a very basic TRACE
request object, which should be suitable for most test cases.
It also reworks the original TestClientTests suite so that the following
conditions are checked:
This fixes https://code.djangoproject.com/ticket/23606