Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #23660 -- Moved sort_dependencies to core. #3372

Closed
wants to merge 1 commit into from

Conversation

collinanderson
Copy link
Contributor

@loic
Copy link
Member

loic commented Oct 15, 2014

Build failed.

@berkerpeksag
Copy link
Contributor

Looks like an ImportError:

ImportError: Failed to import test module: fixtures_regress.tests
Traceback (most recent call last):
  File "/usr/lib/python2.7/unittest/loader.py", line 252, in _find_tests
    module = self._get_module_from_name(name)
  File "/usr/lib/python2.7/unittest/loader.py", line 230, in _get_module_from_name
    __import__(name)
  File "/home/jenkins/workspace/django-pull-requests/database/sqlite3/python/python2.7/tests/fixtures_regress/tests.py", line 14, in <module>
    from django.core.management.commands.dumpdata import sort_dependencies
ImportError: cannot import name sort_dependencies

http://djangoci.com/job/django-pull-requests/1292/database=sqlite3,python=python2.7/testReport/unittest.loader/ModuleImportFailure/tests/

@collinanderson
Copy link
Contributor Author

funny... because I removed that import :)

buildbot, retest this please.

@collinanderson
Copy link
Contributor Author

buildbot, retest this please.

else:
skipped.append((model, deps))
if not changed:
raise Exception("Can't resolve dependencies for %s in serialized app list." %
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we be a little more specific? Maybe RuntimeError since this is akin to 'maximum recursion depth exceeded'?

@loic
Copy link
Member

loic commented Oct 15, 2014

Merged in a6a8268. Thanks!

@loic loic closed this Oct 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants