Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #23321 -- Generated .mo files at setup time #3392

Closed
wants to merge 3 commits into from

Conversation

claudep
Copy link
Member

@claudep claudep commented Oct 19, 2014

No description provided.

@claudep
Copy link
Member Author

claudep commented Oct 20, 2014

In this new version, only the sdist command is always compiling .mo files. Otherwise, python setup.py build_mo can be run to manually compile mo files. We could then even remove the trans_real.py addition of this patch and add the python setup.py build_mo instruction in the documentation at proper places.

@timgraham
Copy link
Member

Code looks fine to me, but someone with experience with translations should offer an opinion on your comment. Is this change transparent to users running with a development version of Django or are some release notes required?

@claudep
Copy link
Member Author

claudep commented Oct 21, 2014

Currently, it should be transparent due to the check added in trans_real.py. But I'm not yet sure it's the right thing to do. This adds a small overhead to every translation setup. The alternative would be to document the need to run python setup.py build_mo when running with a checked-out Django version. More opinions welcome.

@timgraham
Copy link
Member

@jezdez, as former translation manager maybe you could offer an opinion on this?

@jezdez
Copy link
Contributor

jezdez commented Nov 26, 2014

I've marked the ticket as Someday/Maybe on the grounds of this patch not being optimal. If we could somehow get rid of the dependency on the gettext library (e.g. via Babel) that would solve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants