Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #23652 -- Restored database name after destroying test database #3418

Closed
wants to merge 1 commit into from

Conversation

claudep
Copy link
Member

@claudep claudep commented Oct 24, 2014

Thanks Bjarkias for the report.

@timgraham
Copy link
Member

Looks good. How do you feel about backport? Doesn't seem like it's critical functionality that is relied upon if it's been a regression since 1.4. Guess we could at least update the older docs to reflect actual behavior.

@claudep
Copy link
Member Author

claudep commented Oct 24, 2014

I don't see it as critical either. Updating older docs might be a good idea.

@claudep claudep closed this Oct 24, 2014
@claudep claudep deleted the 23652 branch October 24, 2014 15:08
@dcreager
Copy link

We just ran into this with 1.6. Would it be possible to backport this patch?

(For context, we run into this via south's migrationcheck command, which tries to create a new test database for each app with migrations. Before we thought the issue was that migrationcheck wasn't creating the test databases at all, so we used a sqlite in-memory database as a workaround. We just recently tried to update this to use a proper postgres database, to match what's running in prod, which exposed this regression.)

@timgraham
Copy link
Member

As 1.7 as been released, 1.6 only receives security updates per our supported versions policy.

@dcreager
Copy link

Yeah that's what I figured...I thought that since it was simple it might fall under the "developer's discretion" clause. 😄 Ah well, thanks anyway for your hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants