Refs #18586 -- Split up model_inheritance.ModelInheritanceTest #3658
Conversation
|
Waiting until #3464 is merged so we can use |
| s = Supplier.objects.create(name='s1', address='a2') | ||
| def test_filter_inherited_on_null(self): | ||
| """ | ||
| Test isnull lookup in filter() for inherited models. |
There was a problem hiding this comment.
preferred format is "#12567 - Test isnull lookup for inherited models" (although since the test name is fairly descriptive, I'm not sure the docstring really adds much)
alexanderad
force-pushed
the
ticket_18586_model_inheritance_tests
branch
from
46fd135
to
eab7509
Compare
|
@timgraham rebased & updated. |
|
buildbot, test this please. |
|
Hmm, not sure what went wrong with build. |
|
@alexanderad a commit was forced pushed after the build was triggered. |
|
Buildbot, retest this please. |
|
Sorry, one more request I thought of while reviewing some of the other related patches. It would be helpful if only the tests that actually use the test data appear in the test class with |
alexanderad
force-pushed
the
ticket_18586_model_inheritance_tests
branch
from
eab7509
to
b83c184
Compare
|
That make sense. I've updated. I see that previous "build is green" label disappeared with rebased changes, clearly indicating that this needs another test suite run. Neat :-) |
|
buildbot, test this please. |
|
merged in 2cd19f3, thanks! |
https://code.djangoproject.com/ticket/18586