Added RasterSource/GDALBand GDAL objects #3694
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudep
force-pushed
the
raster
branch
2 times, most recently
from
6200276
to
e2c5feb
Compare
|
|
||
| class GDALBand(GDALBase): | ||
| """ | ||
| Wraps a GDAL raster band, needs to be instantiated from a RasterSource object. |
claudep
force-pushed
the
raster
branch
2 times, most recently
from
bc40ace
to
dfffae2
Compare
|
I've rebased/merged all the latest reviews. |
|
@yellowcap Are you planning a second review after the changes I introduced? Do you find them satisfying? |
| PARAMETER["false_easting",400000], | ||
| PARAMETER["false_northing",0], | ||
| UNIT["metre",1, | ||
| AUTHORITY["EPSG","9001"]]] |
There was a problem hiding this comment.
This should probably be updated with the new gdalinfo, which basically includes one more line in the coordinate system:
AUTHORITY["EPSG","3086"]]
|
Just made a few minor comments. Other than those small things I think its good to go. @claudep - the latest updates you made are statisfying, thanks for those! |
Based on Daniel Wiesmann's raster branch. Thanks Daniel Wiesmann and Tim Graham for the reviews. Refs #23804.
|
Unfortunately Jenkins keeps giving unexplained errors, let's not consider its results for this commit. |
|
Merged in 6e08bde |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Daniel Wiesmann's raster branch. Refs #23804.