Fixed #22728 - Prohibited lookups usage for get_or_create #3793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -494,6 +494,10 @@ def _extract_model_params(self, defaults, **kwargs): | |||
| if f.attname in lookup: | |||
| lookup[f.name] = lookup.pop(f.attname) | |||
| params = {k: v for k, v in kwargs.items() if LOOKUP_SEP not in k} | |||
| lookup_parameters = set(kwargs.keys()) - set(params.keys()) | |||
There was a problem hiding this comment.
No need to compute this if lookup_parameters_allowed is True. I don't know the ORM code enough, so you can ignore my comment if it sounds like a premature optimization:
if not lookup_parameters_allowed:
lookup_parameters = set(kwargs.keys()) - set(params.keys())
if lookup_parameters:
# ...
|
Yes, we can also apply this to |
| .. warning:: | ||
|
|
||
| Lookups usage is not allowed for ``get_or_create()``. | ||
| If you will try to use it, ``TypeError`` will be raised:: |
There was a problem hiding this comment.
Stilted sentence up to the comma, IMHO. Perhaps lead with Attempting to ...?
|
@coldmind, do you have time/interest in following up on this? Was thinking we could offer completing it as a task for the DjangoconEU sprints if not. |
|
@timgraham, I'm actually on DjangoConEU now, and also will participate in sprints, but we can propose this task for someone else who had not commited to django before. |
|
New PR: #4779 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch proposes how this problem can be solved.
I decided to make this backwards incompatible, because the way django does it now should not be encouraged.
One more thing - ticket is about
get_or_create, but I thinkupdate_or_createshould have the same behavior.