Fixed #24291 - Fixed migrations with unused swappable models #4071
Conversation
knbk
force-pushed
the
ticket_24291
branch
4 times, most recently
from
3c13277
to
9e6ec6e
Compare
|
Flake8 doesn't fail on my local system. Could someone give me any pointers on how to fix it? |
|
Here you go: |
|
I just double-checked and PEP8 allows single lines to separate blocks. Why did flake8 mark that single blank line as an error? Anyway, it works now. |
knbk
force-pushed
the
ticket_24291
branch
5 times, most recently
from
394ca86
to
5a13791
Compare
|
buildbot, test this please. |
|
Could you also make the use of quotes consistent (single quote everywhere should be fine, I think) |
|
db/migrations/state.py seems to use double quotes almost everywhere, so I used them there as well. tests/migrations/test_state.py was more 50/50 so I switched to consistently using single quotes in the new test. |
|
buildbot, test this please. |
|
With this patch Django creates a migrations for |
|
buildbot, test this please |
| """ | ||
| Tests making a ProjectState from an Apps with a swappable model | ||
| """ | ||
|
|
|
You can squash commits, thanks. |
Changed ModelState from_model to use an empty list when an unused swappable model doesn't explicitly define a manager.
|
Test failure due to failed checkout |
|
Merged in 15dc8d1. Thanks. |
|
I slightly changed the test cases to not use an entire |
Changed ModelState from_model to use an empty list if the model was an unused
swappable model.