Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #19044 -- Allow get_success_url to access self.object in DeletionMixin #417

Closed
wants to merge 1 commit into from
Closed

Fixed #19044 -- Allow get_success_url to access self.object in DeletionMixin #417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions django/views/generic/edit.py
View file
Open in desktop
Expand Up @@ -240,16 +240,17 @@ def delete(self, request, *args, **kwargs):
redirects to the success URL.
"""
self.object = self.get_object()
success_url = self.get_success_url()
self.object.delete()
return HttpResponseRedirect(self.get_success_url())
return HttpResponseRedirect(success_url)

# Add support for browsers which only accept GET and POST for now.
def post(self, *args, **kwargs):
return self.delete(*args, **kwargs)

def get_success_url(self):
if self.success_url:
return self.success_url
return self.success_url % self.object.__dict__
else:
raise ImproperlyConfigured(
"No URL to redirect to. Provide a success_url.")
Expand Down