Fixed #24305 -- Added the ability to shadow abstract fields. #4184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knbk
force-pushed
the
ticket_24305
branch
2 times, most recently
from
ad4d00d
to
ac5bb03
Compare
Allowed to override abstract or virtual fields inherited from base models. Abstract fields can only be overridden if they don't exist on any concrete base model. Overriding with `None` removes the field. Passing `locked=True` to the field disallows overriding that field.
|
Loic indicated this approach isn't ideal and said he may offer his own idea when he was some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowed to override abstract or virtual fields inherited from base
models. Abstract fields can only be overridden if they don't exist
on any concrete base model. Overriding with
Noneremoves the field.Passing
locked=Trueto the field disallows overriding that field.https://code.djangoproject.com/ticket/24305