Fixed #24904 -- Fixed nested namespaces in current_app. #4743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -574,6 +574,25 @@ def test_namespaces_with_variables(self): | |||
| self.assertEqual('/inc70/', reverse('inc-ns5:inner-nothing', args=['70'])) | |||
| self.assertEqual('/inc78/extra/foobar/', reverse('inc-ns5:inner-extra', args=['78', 'foobar'])) | |||
|
|
|||
| def test_nested_app_lookup(self): | |||
| "A nested current_app should be split in individual namespaces: see #24904" | |||
|
For the tests, I really much prefer the indentation I suggested. Indenting a non-multiple of 4 number of spaces and cramming everything on the right side is not very readable in my opinion. |
Fixed reverse() to correctly handled nested namespace lookups in current_app.
|
merged in f0450c9, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed reverse() to correctly handled nested namespace lookups
in current_app.
https://code.djangoproject.com/ticket/24904