Fixed #25005 - Made DateTime and DateTimeField with auto_now/auto_now_add use effective default #4891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -201,6 +202,12 @@ def effective_default(self, field): | |||
| default = six.binary_type() | |||
| else: | |||
| default = six.text_type() | |||
| elif (field.get_internal_type() == 'DateField' | |||
|
Can you combine the autodetector tests to test against all three date related fields at once. |
…_add use effective default Also fixed autodetector in migrations to skip promt for default for these fields.
|
Closing, opened new PR against master (#4902) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/25005
This is PoC.
If
auto_noworauto_now_addare used, no need to ask for default value, need to use effective default.I'm opening it against 1.8, but I doubt if this behavior need to be changed for 1.8.
This changes seems something for 1.9.