Fixed #25081 -- Prevented DISTINCT ON ordering from being cleared in get(). #4974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -129,3 +129,8 @@ def test_distinct_on_in_ordered_subquery(self): | |||
| qs, [self.p1_o2, self.p2_o1, self.p3_o1], | |||
| lambda x: x | |||
| ) | |||
|
|
|||
| def test_distinct_on_get_ordering_preserved(self): | |||
| """#25081 - Ordering shouldn't be cleared when distinct on fields are specified.""" | |||
charettes
force-pushed
the
ticket-25081-get-distinct-on-ordering
branch
from
55541c4
to
8665631
Compare
charettes
force-pushed
the
ticket-25081-get-distinct-on-ordering
branch
from
8665631
to
11e6bf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a regression test for the ordering clearing optimisation performed in
get()since no tests were failing if we simply removed theclone = clone.order_by()below and adjusted a test to correctly test captured queries SQL.