Fixed #24988 -- Documented passing a dictionary of ValidationErrors to ValidationError #5088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -205,6 +205,15 @@ with ``code``\s and ``params`` but a list of strings will also work:: | |||
| _('Error 2'), | |||
| ]) | |||
|
|
|||
| If you detect multiple errors in multiple fields in your form, for instance | |||
There was a problem hiding this comment.
This will only work in Form.clean(), so "for instance" is a little light here.
There was a problem hiding this comment.
It'll also work in Model.clean() obviously but these are the forms docs, which is a bit of a problem, Model.clean() is actually the only place where this pattern is recommended, Form.clean() should use Form.add_error() instead.
There was a problem hiding this comment.
This new snippet should be moved to the model validation docs, then, correct?
timgraham
changed the title
|
Updated and merged in 52a190b, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch for https://code.djangoproject.com/ticket/24988