Fixed #25299 -- Fixed crash with ModelAdmin.list_display value that clashes with a model reverse accessor. #5185
Conversation
|
@PirosB3 Hi Dan, this seems to be a regression due to the meta API changes. Maybe you could review the patch? |
|
Sure! will do that now 2015-08-26 19:17 GMT+02:00 Tim Graham notifications@github.com:
PirosB3 |
| """ | ||
| field = opts.get_field(name) | ||
| if field.is_relation and field.many_to_one and not field.related_model: |
There was a problem hiding this comment.
@timgraham The changes look perfect. I was wondering, isn't is_relation a bit redundant in this case?
There was a problem hiding this comment.
Hm, you did write that original code. 😛
I guess it could be related to the docs that say, "These attribute (field.many_to_one, etc.) are present on all fields; however, they will only have boolean values (rather than None) if the field is a relation type (Field.is_relation=True)." It seems we use a similar pattern of checking is_relation before the field flags elsewhere, so I think it's okay.
|
Looks perfect to me |
…lashes with a model reverse accessor.
https://code.djangoproject.com/ticket/25299