Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #20461 -- Add tblib to py2 requirements.txt #5258

Closed

Conversation

collinanderson
Copy link
Contributor

@bak1an
Copy link
Contributor

bak1an commented Sep 10, 2015

Please add to py3 requirements as well.

@bak1an
Copy link
Contributor

bak1an commented Sep 10, 2015

It also would be helpful to add this to documentation as well, because current wording sounds like "you can install tblib to see pretty stacktraces, but you can skip it if you don't care". This should sound more like "tblib is totally required (at least to run tests in parallel)".

@timgraham
Copy link
Member

This is already in the base.txt requirements file?

@bak1an
Copy link
Contributor

bak1an commented Sep 10, 2015

Please add to py3 requirements as well.

or to base.txt :shipit:

@collinanderson
Copy link
Contributor Author

I think tblib more optional on python3, but I might be wrong. (Because tracebacks are pickable on py3?)

Hah. yup. It's already in base.txt. :)

@bak1an
Copy link
Contributor

bak1an commented Sep 10, 2015

@collinanderson
It crashed withoud tblib on py3.4 for me.

But anyway, I should have missed the actual change within b1a2954 that adds tblib to base.txt while looking for the new requirements to install within diff.

Sorry for a mess :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants