Fixed #25519 -- Added support for SCRIPT_NAME for admin view site #5426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a mention about this behavior in |
|
Should I close this PR and create new with docs or a new PR just for doc will be fine? |
|
You can amend this one. |
Used request.META['SCRIPT_NAME'] to determine if SCRIPT_NAME is set. If it is indeed there and site_url is '/' then used this as site_url Added documentation in docs/ref/contrib/admin/index.rst Modified 1.10 release notes to reflect the same
DheerendraRathor
force-pushed
the
ticket_25519
branch
from
9da5a6a
to
cfc7d01
Compare
|
I've updated the PR with docs and also added the same in 1.10 release notes |
|
merged in 59e85f0, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used request.META['SCRIPT_NAME'] to determine if SCRIPT_NAME is set.
If it is indeed there and site_url is '/' then used this as site_url