Fixed #25585 -- Allowed None to be set as SRID and SRS value for OGRGeometry.
#5458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -320,6 +320,11 @@ def test_srs(self): | |||
| self.assertEqual('WGS 72', ring.srs.name) | |||
| self.assertEqual(4322, ring.srid) | |||
|
|
|||
| # test assigning of SRS and SRID to None | |||
There was a problem hiding this comment.
Minor nit, but I prefer stating the expected behavior like this: # SRS and SRID may be assigned to None. since all tests are obviously for testing things.
sir-sigurd
force-pushed
the
allow-none-for-srid
branch
from
533b64e
to
c9e717a
Compare
timgraham
changed the title
None to be set as SRID and SRS value for `O…None to be set as SRID and SRS value for OGRGeometry.
| # test assigning of SRS and SRID to their own values | ||
| mpoly = OGRGeometry(mp.wkt, srs=None) | ||
| mpoly.srs = mpoly.srs | ||
| mpoly.srid = mpoly.srid |
There was a problem hiding this comment.
Couldn't we simply test setting the srs and srid to None? Is there something specific about using their own values?
There was a problem hiding this comment.
I find it more expressive. It's obvious that attribute should allow assigning to its own value, unlike that attribute should allow assigning to None.
There was a problem hiding this comment.
OK, then the comment might be completed by "even when srs is None".
|
Comment updated and merged in 0dbe897, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/25585