Fixed #25636: Dropped support for SpatiaLite < 3.0. #5518
Conversation
sir-sigurd
force-pushed
the
25636-drop-support-for-old-spatialite
branch
2 times, most recently
from
09fd828
to
5932a8e
Compare
| @@ -13,7 +13,7 @@ Program Description Required | |||
| :doc:`GDAL <../gdal>` Geospatial Data Abstraction Library Yes (SQLite only) 2.0, 1.11, 1.10, 1.9, 1.8, 1.7 | |||
| :doc:`GeoIP <../geoip>` IP-based geolocation library No 1.4 | |||
| `PostGIS`__ Spatial extensions for PostgreSQL Yes (PostgreSQL only) 2.1, 2.0 | |||
| `SpatiaLite`__ Spatial extensions for SQLite Yes (SQLite only) 4.1, 4.0, 3.0, 2.4 | |||
| `SpatiaLite`__ Spatial extensions for SQLite Yes (SQLite only) 4.3, 4.2, 4.1, 4.0, 3.0 | |||
There was a problem hiding this comment.
It would be appropriate to pull out the "4.3, 4.2" additions into a separate commit so we can backport that as appropriate.
sir-sigurd
force-pushed
the
25636-drop-support-for-old-spatialite
branch
from
5932a8e
to
7314b75
Compare
| @@ -64,6 +64,8 @@ Minor features | |||
| * :ref:`Distance lookups <distance-lookups>` now accept expressions as the | |||
| distance value parameter. | |||
|
|
|||
| * Support for SpatiaLite < 3.0 has been dropped. | |||
There was a problem hiding this comment.
A minor thing that nags me in the past release notes.... for consistency with the "Features removed" section, let's use "is" instead of "has been".
sir-sigurd
force-pushed
the
25636-drop-support-for-old-spatialite
branch
from
7314b75
to
78e93f1
Compare
|
There are some "(from v3.0)" string on db-api.txt which could be changed. Any thoughts about what to do with install/spatialite.txt which reference libspatialite-amalgamation-2.4? |
|
I'll try to update this instruction. |
| @@ -489,8 +480,6 @@ def test_diff_intersection_union(self): | |||
| pass | |||
| else: | |||
| self.assertEqual(c.mpoly.difference(geom), c.difference) | |||
| if not spatialite: | |||
| self.assertEqual(c.mpoly.intersection(geom), c.intersection) | |||
There was a problem hiding this comment.
This test assertion should not be removed, only the condition should.
|
@claudep Why do we need spatialite-tools in install/spatialite.txt? |
|
Hard to tell as I'm generally not installing from sources myself. It might be handy for inspecting the database in the command line, but I cannot say if it's required or not. |
|
Then I will delete it, because I built only libspatialite and it works for me. |
sir-sigurd
force-pushed
the
25636-drop-support-for-old-spatialite
branch
from
78e93f1
to
95a99ff
Compare
| @@ -64,6 +64,8 @@ Minor features | |||
| * :ref:`Distance lookups <distance-lookups>` now accept expressions as the | |||
| distance value parameter. | |||
|
|
|||
| * Support for SpatiaLite < 3.0 is dropped. | |||
There was a problem hiding this comment.
This goes under "Backwards-incompatible changes" not "Minor features". Sorry I missed it before.
sir-sigurd
force-pushed
the
25636-drop-support-for-old-spatialite
branch
from
95a99ff
to
6d7cab9
Compare
No description provided.