Fixed #19536 -- Show object-tools when has_add_permission is False. #5573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,6 +35,8 @@ Minor features | |||
| * For sites running on a subpath, the default :attr:`URL for the "View site" | |||
| link <django.contrib.admin.AdminSite.site_url>` at the top of each admin page | |||
| will now point to ``request.META['SCRIPT_NAME']`` if set, instead of ``/``. | |||
| * On a ``ModelAdmin``'s changelist, if a user has no add permission the | |||
| m = EventAdmin(Event, custom_site) | ||
| request = self._mocked_authenticated_request('/event/', superuser) | ||
| response = m.changelist_view(request) | ||
| self.assertIn('<ul class="object-tools">', response.rendered_content) |
There was a problem hiding this comment.
should we also assert that "Add {{ name }}" isn't shown? If there's already a test for that, maybe we could simply modify that one?
|
Hi Nick, do you have time to follow up on this or at least response to my question about the |
|
merged in ff19df9, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.